From: Carlos Garnacho <carlosg@gnome.org>
Date: Sun, 5 Jan 2020 19:17:38 +0000 (+0100)
Subject: popover: Use g_signal_connect_object on parent widget signal
X-Git-Tag: archive/raspbian/4.4.1+ds1-2+rpi1~1^2~321^2^2~354^2~96
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=dbb3727b0375e4aeb57e054c526f35420ebf46e6;p=gtk4.git

popover: Use g_signal_connect_object on parent widget signal

The popover may be destroyed, leaving this dangling signal. This
may cause crashes on future parent widget resizes.
---

diff --git a/gtk/gtkpopover.c b/gtk/gtkpopover.c
index bcda0fdd50..a963b35110 100644
--- a/gtk/gtkpopover.c
+++ b/gtk/gtkpopover.c
@@ -1482,7 +1482,8 @@ gtk_popover_set_relative_to (GtkPopover *popover,
 
   if (priv->relative_to)
     {
-      g_signal_connect (priv->relative_to, "size-allocate", G_CALLBACK (size_changed), popover);
+      g_signal_connect_object (priv->relative_to, "size-allocate",
+                               G_CALLBACK (size_changed), popover, 0);
       gtk_css_node_set_parent (gtk_widget_get_css_node (GTK_WIDGET (popover)),
                                gtk_widget_get_css_node (relative_to));
       gtk_widget_set_parent (GTK_WIDGET (popover), relative_to);